śr., 5 gru 2018 o 13:20 Linus Walleij <linus.walleij@xxxxxxxxxx> napisał(a): > > On Mon, Dec 3, 2018 at 12:06 PM Uwe Kleine-König > <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > On Mon, Dec 03, 2018 at 11:57:26AM +0100, Bartosz Golaszewski wrote: > > > > It used to live in the gpio-mockup driver and I generalized it > > > precisely because there was another driver - iio evgen - which was > > > doing basically the same thing. While I don't know if there'll be more > > > users (I'd guess it would be useful for testing purposes of other > > > subsystems) having the same functionality implemented once is better > > > than twice. > > > > The iio testing driver only needs the trigger and relies on an irq that > > then calls the registerd handler. The iio driver doesn't need to tune > > the edge sensitivity though and if your mockup driver just only calls > > the fire routine if the configured sensitivity justifies that, > > everything should work as expected. > > Simulating edges in the generic IRQ simulator codes seems > generally useful to me, even if there is just one user now. > > Certainly for any kind of IRQ testing, it could be interesting to > throw several low-to-high and high-to-low transitions > on a driver and see how it reacts. > > But it is up to the irqchip maintainers to state whether they > agree. > All that would be great, but at this point I just want to fix broken tests in user-space. After that we can think about how to improve/approach simulating interrupts all we want. Marc: is my explanation for using an int instead of bool for irq_sim_fire_edge() fine? Can Linus pick this up for fixes? Bart