On 12/03/2018 10:36 AM, Bartosz Golaszewski wrote: > niedz., 2 gru 2018 o 20:36 Marek Vasut <marek.vasut@xxxxxxxxx> napisał(a): >> >> The bank_size = fls(...) code was duplicated in the driver 5 times, >> pull it into separate function. >> > > Shouldn't it be bank_shift in the commit message? It should, fixed -- Best regards, Marek Vasut
Re: [PATCH 01/14] gpio: pca953x: Deduplicate the bank_size
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 01/14] gpio: pca953x: Deduplicate the bank_size
- From: Marek Vasut <marek.vasut@xxxxxxxxx>
- Date: Mon, 3 Dec 2018 12:00:09 +0100
- In-reply-to: <CAMpxmJV++wAmkF28CK9vO5Zia7Sd9zVyAw+Y_C=qci_0oWHLog@mail.gmail.com>
- References: <20181202193553.29704-1-marek.vasut+renesas@gmail.com> <CAMpxmJV++wAmkF28CK9vO5Zia7Sd9zVyAw+Y_C=qci_0oWHLog@mail.gmail.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
- References:
- [PATCH 01/14] gpio: pca953x: Deduplicate the bank_size
- From: Marek Vasut
- Re: [PATCH 01/14] gpio: pca953x: Deduplicate the bank_size
- From: Bartosz Golaszewski
- [PATCH 01/14] gpio: pca953x: Deduplicate the bank_size
- Prev by Date: Re: [PATCH 2/2] gpio: mockup: use irq_sim_fire_edge()
- Next by Date: Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs
- Previous by thread: Re: [PATCH 01/14] gpio: pca953x: Deduplicate the bank_size
- Next by thread: [PATCH v6 00/17] initial support for "suniv" Allwinner new ARM9 SoC
- Index(es):
 |