On Wed, Nov 28, 2018 at 05:57:56PM +0100, Hans de Goede wrote: > acpi_gpiochip_alloc_event only continues allocating an event and adding > it to the list if gpiochip_request_own_desc does not return an error. > So events with an error desc are never placed on the events list and this > check is really not necessary. > > Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Re: [PATCH v2 2/2] gpiolib-acpi: Remove unnecessary WARN_ON from acpi_gpiochip_free_interrupts
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 2/2] gpiolib-acpi: Remove unnecessary WARN_ON from acpi_gpiochip_free_interrupts
- From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
- Date: Thu, 29 Nov 2018 10:54:21 +0200
- In-reply-to: <20181128165756.20908-2-hdegoede@redhat.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20181128165756.20908-1-hdegoede@redhat.com> <20181128165756.20908-2-hdegoede@redhat.com>
- User-agent: Mutt/1.10.1 (2018-07-13)
- References:
- Prev by Date: Re: [PATCH v2 1/2] gpiolib-acpi: Only defer request_irq for GpioInt ACPI event handlers
- Next by Date: Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs
- Previous by thread: [PATCH v2 2/2] gpiolib-acpi: Remove unnecessary WARN_ON from acpi_gpiochip_free_interrupts
- Next by thread: Re: [PATCH v2 2/2] gpiolib-acpi: Remove unnecessary WARN_ON from acpi_gpiochip_free_interrupts
- Index(es):
 |