Hi Charles, I love your patch! Yet something to improve: [auto build test ERROR on ljones-mfd/for-mfd-next] [also build test ERROR on v4.20-rc3] [cannot apply to next-20181123] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Charles-Keepax/regulator-lochnagar-Move-driver-to-binding-from-DT/20181123-133943 base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >> drivers/regulator/lochnagar-regulator.c:115:21: error: undefined identifier 'LOCHNAGAR2_P2_MICBIAS_SRC_SHIFT' >> drivers/regulator/lochnagar-regulator.c:116:20: error: undefined identifier 'LOCHNAGAR2_P1_MICBIAS_SRC_MASK' >> drivers/regulator/lochnagar-regulator.c:123:23: error: undefined identifier 'LOCHNAGAR2_ANALOGUE_PATH_CTRL2' >> drivers/regulator/lochnagar-regulator.c:148:31: error: undefined identifier 'LOCHNAGAR2_MICVDD_CTRL1' >> drivers/regulator/lochnagar-regulator.c:149:32: error: undefined identifier 'LOCHNAGAR2_MICVDD_REG_ENA_MASK' >> drivers/regulator/lochnagar-regulator.c:150:29: error: undefined identifier 'LOCHNAGAR2_MICVDD_CTRL2' >> drivers/regulator/lochnagar-regulator.c:151:30: error: undefined identifier 'LOCHNAGAR2_MICVDD_VSEL_MASK' drivers/regulator/lochnagar-regulator.c:171:31: error: undefined identifier 'LOCHNAGAR2_ANALOGUE_PATH_CTRL2' >> drivers/regulator/lochnagar-regulator.c:172:32: error: undefined identifier 'LOCHNAGAR2_P1_INPUT_BIAS_ENA_MASK' drivers/regulator/lochnagar-regulator.c:186:31: error: undefined identifier 'LOCHNAGAR2_ANALOGUE_PATH_CTRL2' >> drivers/regulator/lochnagar-regulator.c:187:32: error: undefined identifier 'LOCHNAGAR2_P2_INPUT_BIAS_ENA_MASK' >> drivers/regulator/lochnagar-regulator.c:201:31: error: undefined identifier 'LOCHNAGAR2_VDDCORE_CDC_CTRL1' >> drivers/regulator/lochnagar-regulator.c:202:32: error: undefined identifier 'LOCHNAGAR2_VDDCORE_CDC_REG_ENA_MASK' >> drivers/regulator/lochnagar-regulator.c:203:29: error: undefined identifier 'LOCHNAGAR2_VDDCORE_CDC_CTRL2' >> drivers/regulator/lochnagar-regulator.c:204:30: error: undefined identifier 'LOCHNAGAR2_VDDCORE_CDC_VSEL_MASK' drivers/regulator/lochnagar-regulator.c: In function 'lochnagar_micbias_of_parse': drivers/regulator/lochnagar-regulator.c:115:7: error: 'LOCHNAGAR2_P2_MICBIAS_SRC_SHIFT' undeclared (first use in this function); did you mean 'LOCHNAGAR_DEVICE_ID_SHIFT'? LOCHNAGAR2_P2_MICBIAS_SRC_SHIFT; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ LOCHNAGAR_DEVICE_ID_SHIFT drivers/regulator/lochnagar-regulator.c:115:7: note: each undeclared identifier is reported only once for each function it appears in drivers/regulator/lochnagar-regulator.c:116:13: error: 'LOCHNAGAR2_P1_MICBIAS_SRC_MASK' undeclared (first use in this function); did you mean 'LOCHNAGAR2_P2_MICBIAS_SRC_SHIFT'? int mask = LOCHNAGAR2_P1_MICBIAS_SRC_MASK << shift; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ LOCHNAGAR2_P2_MICBIAS_SRC_SHIFT In file included from drivers/regulator/lochnagar-regulator.c:18:0: drivers/regulator/lochnagar-regulator.c:124:7: error: 'LOCHNAGAR2_ANALOGUE_PATH_CTRL2' undeclared (first use in this function) LOCHNAGAR2_ANALOGUE_PATH_CTRL2, ^ include/linux/regmap.h:77:31: note: in definition of macro 'regmap_update_bits' regmap_update_bits_base(map, reg, mask, val, NULL, false, false) ^~~ drivers/regulator/lochnagar-regulator.c: At top level: drivers/regulator/lochnagar-regulator.c:148:17: error: 'LOCHNAGAR2_MICVDD_CTRL1' undeclared here (not in a function); did you mean 'LOCHNAGAR_MICVDD'? .enable_reg = LOCHNAGAR2_MICVDD_CTRL1, ^~~~~~~~~~~~~~~~~~~~~~~ LOCHNAGAR_MICVDD drivers/regulator/lochnagar-regulator.c:149:18: error: 'LOCHNAGAR2_MICVDD_REG_ENA_MASK' undeclared here (not in a function); did you mean 'LOCHNAGAR2_MICVDD_CTRL1'? .enable_mask = LOCHNAGAR2_MICVDD_REG_ENA_MASK, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ LOCHNAGAR2_MICVDD_CTRL1 drivers/regulator/lochnagar-regulator.c:150:15: error: 'LOCHNAGAR2_MICVDD_CTRL2' undeclared here (not in a function); did you mean 'LOCHNAGAR2_MICVDD_CTRL1'? .vsel_reg = LOCHNAGAR2_MICVDD_CTRL2, ^~~~~~~~~~~~~~~~~~~~~~~ LOCHNAGAR2_MICVDD_CTRL1 drivers/regulator/lochnagar-regulator.c:151:16: error: 'LOCHNAGAR2_MICVDD_VSEL_MASK' undeclared here (not in a function); did you mean 'LOCHNAGAR2_MICVDD_REG_ENA_MASK'? .vsel_mask = LOCHNAGAR2_MICVDD_VSEL_MASK, ^~~~~~~~~~~~~~~~~~~~~~~~~~~ LOCHNAGAR2_MICVDD_REG_ENA_MASK drivers/regulator/lochnagar-regulator.c:171:17: error: 'LOCHNAGAR2_ANALOGUE_PATH_CTRL2' undeclared here (not in a function); did you mean 'LOCHNAGAR2_MICVDD_CTRL2'? .enable_reg = LOCHNAGAR2_ANALOGUE_PATH_CTRL2, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ LOCHNAGAR2_MICVDD_CTRL2 drivers/regulator/lochnagar-regulator.c:172:18: error: 'LOCHNAGAR2_P1_INPUT_BIAS_ENA_MASK' undeclared here (not in a function); did you mean 'LOCHNAGAR2_MICVDD_REG_ENA_MASK'? .enable_mask = LOCHNAGAR2_P1_INPUT_BIAS_ENA_MASK, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ LOCHNAGAR2_MICVDD_REG_ENA_MASK drivers/regulator/lochnagar-regulator.c:187:18: error: 'LOCHNAGAR2_P2_INPUT_BIAS_ENA_MASK' undeclared here (not in a function); did you mean 'LOCHNAGAR2_P1_INPUT_BIAS_ENA_MASK'? .enable_mask = LOCHNAGAR2_P2_INPUT_BIAS_ENA_MASK, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ LOCHNAGAR2_P1_INPUT_BIAS_ENA_MASK drivers/regulator/lochnagar-regulator.c:201:17: error: 'LOCHNAGAR2_VDDCORE_CDC_CTRL1' undeclared here (not in a function); did you mean 'LOCHNAGAR2_MICVDD_CTRL1'? .enable_reg = LOCHNAGAR2_VDDCORE_CDC_CTRL1, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ LOCHNAGAR2_MICVDD_CTRL1 drivers/regulator/lochnagar-regulator.c:202:18: error: 'LOCHNAGAR2_VDDCORE_CDC_REG_ENA_MASK' undeclared here (not in a function); did you mean 'LOCHNAGAR2_MICVDD_REG_ENA_MASK'? .enable_mask = LOCHNAGAR2_VDDCORE_CDC_REG_ENA_MASK, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ LOCHNAGAR2_MICVDD_REG_ENA_MASK drivers/regulator/lochnagar-regulator.c:203:15: error: 'LOCHNAGAR2_VDDCORE_CDC_CTRL2' undeclared here (not in a function); did you mean 'LOCHNAGAR2_VDDCORE_CDC_CTRL1'? .vsel_reg = LOCHNAGAR2_VDDCORE_CDC_CTRL2, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ LOCHNAGAR2_VDDCORE_CDC_CTRL1 drivers/regulator/lochnagar-regulator.c:204:16: error: 'LOCHNAGAR2_VDDCORE_CDC_VSEL_MASK' undeclared here (not in a function); did you mean 'LOCHNAGAR2_VDDCORE_CDC_REG_ENA_MASK'? .vsel_mask = LOCHNAGAR2_VDDCORE_CDC_VSEL_MASK, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ LOCHNAGAR2_VDDCORE_CDC_REG_ENA_MASK vim +/LOCHNAGAR2_P2_MICBIAS_SRC_SHIFT +115 drivers/regulator/lochnagar-regulator.c bef9391c Charles Keepax 2018-10-08 108 bef9391c Charles Keepax 2018-10-08 109 static int lochnagar_micbias_of_parse(struct device_node *np, bef9391c Charles Keepax 2018-10-08 110 const struct regulator_desc *desc, bef9391c Charles Keepax 2018-10-08 111 struct regulator_config *config) bef9391c Charles Keepax 2018-10-08 112 { bef9391c Charles Keepax 2018-10-08 113 struct lochnagar *lochnagar = config->driver_data; bef9391c Charles Keepax 2018-10-08 114 int shift = (desc->id - LOCHNAGAR_MIC1VDD) * bef9391c Charles Keepax 2018-10-08 @115 LOCHNAGAR2_P2_MICBIAS_SRC_SHIFT; bef9391c Charles Keepax 2018-10-08 @116 int mask = LOCHNAGAR2_P1_MICBIAS_SRC_MASK << shift; bef9391c Charles Keepax 2018-10-08 117 unsigned int val; bef9391c Charles Keepax 2018-10-08 118 int ret; bef9391c Charles Keepax 2018-10-08 119 bef9391c Charles Keepax 2018-10-08 120 ret = of_property_read_u32(np, "cirrus,micbias-input", &val); bef9391c Charles Keepax 2018-10-08 121 if (ret >= 0) { bef9391c Charles Keepax 2018-10-08 122 mutex_lock(&lochnagar->analogue_config_lock); bef9391c Charles Keepax 2018-10-08 @123 ret = regmap_update_bits(lochnagar->regmap, bef9391c Charles Keepax 2018-10-08 124 LOCHNAGAR2_ANALOGUE_PATH_CTRL2, bef9391c Charles Keepax 2018-10-08 125 mask, val << shift); bef9391c Charles Keepax 2018-10-08 126 mutex_unlock(&lochnagar->analogue_config_lock); bef9391c Charles Keepax 2018-10-08 127 if (ret < 0) { bef9391c Charles Keepax 2018-10-08 128 dev_err(lochnagar->dev, bef9391c Charles Keepax 2018-10-08 129 "Failed to update micbias source: %d\n", ret); bef9391c Charles Keepax 2018-10-08 130 return ret; bef9391c Charles Keepax 2018-10-08 131 } bef9391c Charles Keepax 2018-10-08 132 } bef9391c Charles Keepax 2018-10-08 133 bef9391c Charles Keepax 2018-10-08 134 return 0; bef9391c Charles Keepax 2018-10-08 135 } bef9391c Charles Keepax 2018-10-08 136 bef9391c Charles Keepax 2018-10-08 137 static const struct regulator_desc lochnagar_regulators[] = { bef9391c Charles Keepax 2018-10-08 138 [LOCHNAGAR_MICVDD] = { bef9391c Charles Keepax 2018-10-08 139 .name = "MICVDD", bef9391c Charles Keepax 2018-10-08 140 .supply_name = "SYSVDD", bef9391c Charles Keepax 2018-10-08 141 .type = REGULATOR_VOLTAGE, bef9391c Charles Keepax 2018-10-08 142 .n_voltages = 32, bef9391c Charles Keepax 2018-10-08 143 .ops = &lochnagar_micvdd_ops, bef9391c Charles Keepax 2018-10-08 144 bef9391c Charles Keepax 2018-10-08 145 .id = LOCHNAGAR_MICVDD, bef9391c Charles Keepax 2018-10-08 146 .of_match = of_match_ptr("MICVDD"), bef9391c Charles Keepax 2018-10-08 147 bef9391c Charles Keepax 2018-10-08 @148 .enable_reg = LOCHNAGAR2_MICVDD_CTRL1, bef9391c Charles Keepax 2018-10-08 @149 .enable_mask = LOCHNAGAR2_MICVDD_REG_ENA_MASK, bef9391c Charles Keepax 2018-10-08 @150 .vsel_reg = LOCHNAGAR2_MICVDD_CTRL2, bef9391c Charles Keepax 2018-10-08 @151 .vsel_mask = LOCHNAGAR2_MICVDD_VSEL_MASK, bef9391c Charles Keepax 2018-10-08 152 bef9391c Charles Keepax 2018-10-08 153 .linear_ranges = lochnagar_micvdd_ranges, bef9391c Charles Keepax 2018-10-08 154 .n_linear_ranges = ARRAY_SIZE(lochnagar_micvdd_ranges), bef9391c Charles Keepax 2018-10-08 155 bef9391c Charles Keepax 2018-10-08 156 .enable_time = 3000, bef9391c Charles Keepax 2018-10-08 157 .ramp_delay = 1000, bef9391c Charles Keepax 2018-10-08 158 bef9391c Charles Keepax 2018-10-08 159 .owner = THIS_MODULE, bef9391c Charles Keepax 2018-10-08 160 }, bef9391c Charles Keepax 2018-10-08 161 [LOCHNAGAR_MIC1VDD] = { bef9391c Charles Keepax 2018-10-08 162 .name = "MIC1VDD", bef9391c Charles Keepax 2018-10-08 163 .supply_name = "MICBIAS1", bef9391c Charles Keepax 2018-10-08 164 .type = REGULATOR_VOLTAGE, bef9391c Charles Keepax 2018-10-08 165 .ops = &lochnagar_micbias_ops, bef9391c Charles Keepax 2018-10-08 166 bef9391c Charles Keepax 2018-10-08 167 .id = LOCHNAGAR_MIC1VDD, bef9391c Charles Keepax 2018-10-08 168 .of_match = of_match_ptr("MIC1VDD"), bef9391c Charles Keepax 2018-10-08 169 .of_parse_cb = lochnagar_micbias_of_parse, bef9391c Charles Keepax 2018-10-08 170 bef9391c Charles Keepax 2018-10-08 171 .enable_reg = LOCHNAGAR2_ANALOGUE_PATH_CTRL2, bef9391c Charles Keepax 2018-10-08 @172 .enable_mask = LOCHNAGAR2_P1_INPUT_BIAS_ENA_MASK, bef9391c Charles Keepax 2018-10-08 173 bef9391c Charles Keepax 2018-10-08 174 .owner = THIS_MODULE, bef9391c Charles Keepax 2018-10-08 175 }, bef9391c Charles Keepax 2018-10-08 176 [LOCHNAGAR_MIC2VDD] = { bef9391c Charles Keepax 2018-10-08 177 .name = "MIC2VDD", bef9391c Charles Keepax 2018-10-08 178 .supply_name = "MICBIAS2", bef9391c Charles Keepax 2018-10-08 179 .type = REGULATOR_VOLTAGE, bef9391c Charles Keepax 2018-10-08 180 .ops = &lochnagar_micbias_ops, bef9391c Charles Keepax 2018-10-08 181 bef9391c Charles Keepax 2018-10-08 182 .id = LOCHNAGAR_MIC2VDD, bef9391c Charles Keepax 2018-10-08 183 .of_match = of_match_ptr("MIC2VDD"), bef9391c Charles Keepax 2018-10-08 184 .of_parse_cb = lochnagar_micbias_of_parse, bef9391c Charles Keepax 2018-10-08 185 bef9391c Charles Keepax 2018-10-08 186 .enable_reg = LOCHNAGAR2_ANALOGUE_PATH_CTRL2, bef9391c Charles Keepax 2018-10-08 @187 .enable_mask = LOCHNAGAR2_P2_INPUT_BIAS_ENA_MASK, bef9391c Charles Keepax 2018-10-08 188 bef9391c Charles Keepax 2018-10-08 189 .owner = THIS_MODULE, bef9391c Charles Keepax 2018-10-08 190 }, bef9391c Charles Keepax 2018-10-08 191 [LOCHNAGAR_VDDCORE] = { bef9391c Charles Keepax 2018-10-08 192 .name = "VDDCORE", bef9391c Charles Keepax 2018-10-08 193 .supply_name = "SYSVDD", bef9391c Charles Keepax 2018-10-08 194 .type = REGULATOR_VOLTAGE, bef9391c Charles Keepax 2018-10-08 195 .n_voltages = 57, bef9391c Charles Keepax 2018-10-08 196 .ops = &lochnagar_vddcore_ops, bef9391c Charles Keepax 2018-10-08 197 bef9391c Charles Keepax 2018-10-08 198 .id = LOCHNAGAR_VDDCORE, bef9391c Charles Keepax 2018-10-08 199 .of_match = of_match_ptr("VDDCORE"), bef9391c Charles Keepax 2018-10-08 200 bef9391c Charles Keepax 2018-10-08 @201 .enable_reg = LOCHNAGAR2_VDDCORE_CDC_CTRL1, bef9391c Charles Keepax 2018-10-08 @202 .enable_mask = LOCHNAGAR2_VDDCORE_CDC_REG_ENA_MASK, bef9391c Charles Keepax 2018-10-08 @203 .vsel_reg = LOCHNAGAR2_VDDCORE_CDC_CTRL2, bef9391c Charles Keepax 2018-10-08 @204 .vsel_mask = LOCHNAGAR2_VDDCORE_CDC_VSEL_MASK, bef9391c Charles Keepax 2018-10-08 205 bef9391c Charles Keepax 2018-10-08 206 .linear_ranges = lochnagar_vddcore_ranges, bef9391c Charles Keepax 2018-10-08 207 .n_linear_ranges = ARRAY_SIZE(lochnagar_vddcore_ranges), bef9391c Charles Keepax 2018-10-08 208 bef9391c Charles Keepax 2018-10-08 209 .enable_time = 3000, bef9391c Charles Keepax 2018-10-08 210 .ramp_delay = 1000, bef9391c Charles Keepax 2018-10-08 211 bef9391c Charles Keepax 2018-10-08 212 .owner = THIS_MODULE, bef9391c Charles Keepax 2018-10-08 213 }, bef9391c Charles Keepax 2018-10-08 214 }; bef9391c Charles Keepax 2018-10-08 215 :::::: The code at line 115 was first introduced by commit :::::: bef9391cbec547351c6a13e52f3a26bb2d271ec7 regulator: lochnagar: Add support for the Cirrus Logic Lochnagar :::::: TO: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx> :::::: CC: Mark Brown <broonie@xxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
