Re: Fwd: PXA27X and PINCTRL (gpio-pxa.c)

[Robert Jarzmik <robert.jarzmik@xxxxxxx>]

Greg <greguu@xxxxxxxx> writes:

> I forgot to mention that the issue occurs when platform PINCTRL is
> disabled in .config.

Ok, let's talk about the issue then. The report I have from you is :
> The issue I found is that even if PINCTRL is disabled in .config it needs to
> be specified also in gpio-pxa.c to return false for PXA27X_GPIO as
> otherwise we have issues with our keyboard.

This is a bit blurry, what are these "issues" exactly ? And are you talking
about the support in arch/arm/mach-pxa/poodle.c, where I don't see any keyboard
support ?

Moreover, having pxa_gpio_has_pinctrl() return false bypasses this code :
	ret = pinctrl_gpio_direction_input(chip->base + offset);
	if (!ret)
			return 0;
But when CONFIG_PINCTRL=n, we have :
	static inline int pinctrl_gpio_direction_input(unsigned gpio)
	{
		return 0;
	}

Which means your change shouldn't make any difference if you really have
CONFIG_PINCTRL=n.

Cheers.

-- 
Robert