Re: [PATCH v4 3/4] pinctrl: sh-pfc: r8a77965: Add VIN[4|5] groups/functions

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Tue, Nov 6, 2018 at 11:35 AM Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> wrote:
> The VIN4 and VIN5 interfaces supports parallel video input.
> Add pin, mux and functions definitions for VIN4 and VIN5 for R-Car M3-N.
>
> Reviewed-by: Ulrich Hecht <uli+renesas@xxxxxxxx>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>

> --- a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77965.c

Oops, found two more...

> +/* - VIN5 ------------------------------------------------------------------- */
> +static const union vin_data vin5_data_pins = {

union vin_data16

> +       .data16 = {
> +               RCAR_GP_PIN(0, 0), RCAR_GP_PIN(0, 1),
> +               RCAR_GP_PIN(0, 2), RCAR_GP_PIN(0, 3),
> +               RCAR_GP_PIN(0, 4), RCAR_GP_PIN(0, 5),
> +               RCAR_GP_PIN(0, 6), RCAR_GP_PIN(0, 7),
> +               RCAR_GP_PIN(1, 12), RCAR_GP_PIN(1, 13),
> +               RCAR_GP_PIN(1, 14), RCAR_GP_PIN(1, 15),
> +               RCAR_GP_PIN(1, 4),  RCAR_GP_PIN(1, 5),
> +               RCAR_GP_PIN(1, 6),  RCAR_GP_PIN(1, 7),
> +       },
> +};
> +
> +static const union vin_data vin5_data_mux = {

union vin_data16

> +       .data16 = {
> +               VI5_DATA0_MARK, VI5_DATA1_MARK,
> +               VI5_DATA2_MARK, VI5_DATA3_MARK,
> +               VI5_DATA4_MARK, VI5_DATA5_MARK,
> +               VI5_DATA6_MARK, VI5_DATA7_MARK,
> +               VI5_DATA8_MARK,  VI5_DATA9_MARK,
> +               VI5_DATA10_MARK, VI5_DATA11_MARK,
> +               VI5_DATA12_MARK, VI5_DATA13_MARK,
> +               VI5_DATA14_MARK, VI5_DATA15_MARK,
> +       },
> +};

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds