Re: [PATCH V4 04/10] gpio: vf610: add optional clock support

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Nov 2, 2018 at 10:12 AM A.s. Dong <aisheng.dong@xxxxxxx> wrote:

> Some SoCs need the gpio clock to be enabled before accessing
> HW registers. This patch add the optional clock handling.
>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Stefan Agner <stefan@xxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> ---
> v2->v3:
>  * error checking updated according to Russell's suggestion:
>    ptr == ERR_PTR(-EPROBE_DEFER)
>  * clock independently checking

Please look at my feedback for v2 as well, sorry for
the synchronization problems here... Didn't see this
version until after replying.

Yours,
Linus Walleij