Re: [PATCH 2/2] gpio: drop devm_gpiochip_remove()

[Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>]

Hello Linus,

On Wed, Oct 10, 2018 at 01:35:48PM +0200, Linus Walleij wrote:
> On Fri, Oct 5, 2018 at 9:42 PM Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> 
> > There is hardly any reason to call devm_gpiochip_remove() because the
> > driver core handles calling gpiochip_remove() automatically.
> >
> > To make it harder to introduce new (and probably unneeded) callers, drop
> > the function.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> Why not. If somebody legitimately needs it this is easy to reimplement by
> just looking at this commit.
> 
> But I have to wait until the next kernel cycle with this because of
> late in the cycle and cross-tree issues. I don't want to create merge
> conflicts right now (this patch does due to other changes).
> 
> Could you resend this at v4.20-rc1 please?

I don't see a commit that would conflict with my patch between 4.18 and
current next master apart from patches in your tree.

What am I missing?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |