Re: [PATCH v4 2/6] pinctrl: sh-pfc: r8a77470: Add SDHI support

[Simon Horman <horms@xxxxxxxxxxxx>]

On Wed, Oct 17, 2018 at 09:14:19AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> Thank you for your feedback.
> 
> > >
> > > +static int r8a77470_pin_to_pocctrl(struct sh_pfc *pfc, unsigned int pin,
> > > +   u32 *pocctrl)
> > > +{
> > > +int bit = -EINVAL;
> > > +
> > > +*pocctrl = 0xe60600b0;
> > > +
> > > +if (pin >= RCAR_GP_PIN(0, 5) && pin <= RCAR_GP_PIN(0, 10))
> > > +bit = 0;
> >
> > Is it intentional that the range above excludes GP0_11 and 12?
> 
> Yes, it is, GPO_11 and GPO_12 can't be voltage controlled, they only work at 3.3V
> 
> >
> > > +
> > > +if (pin >= RCAR_GP_PIN(0, 13) && pin <= RCAR_GP_PIN(0, 22))
> > > +bit = 2;
> > > +
> > > +if (pin >= RCAR_GP_PIN(4, 14) && pin <= RCAR_GP_PIN(4, 19))
> >
> > And likewise GP4_20 and 21 here.
> 
> Same thing here, GP4_20 and GP4_21 can't be voltage controlled, they only work at 3.3V

Thanks for the follow-up. This patch looks fine to me.

Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>