Re: [PATCH] pinctrl: rzn1: remove unnecessary unsigned integer comparison

["Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>]

On 10/12/18 11:17 AM, Linus Walleij wrote:
> Sorry for top-posting, Geert is maintainer for this driver.
> 

Oh okay.

This is what I get when I run the get_maintainer scripts on the rzn1 driver:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers/pinctrl/pinctrl-rzn1.c
Linus Walleij <linus.walleij@xxxxxxxxxx> (maintainer:PIN CONTROL SUBSYSTEM)
linux-gpio@xxxxxxxxxxxxxxx (open list:PIN CONTROL SUBSYSTEM)
linux-kernel@xxxxxxxxxxxxxxx (open list)

Thanks
--
Gustavo

> Yours,
> Linus Walleij
> 
> On Thu, Oct 11, 2018 at 10:40 PM Gustavo A. R. Silva
> <gustavo@xxxxxxxxxxxxxx> wrote:
>>
>> There is no need to compare ipctl->mdio_func[mdio] with => 0, because
>> such comparison is always true. Notice that *mdio_func* is of type
>> u32 (32 bits, unsigned).
>>
>> Fix this by removing such comparison.
>>
>> Addresses-Coverity-ID: 1474166 ("Unsigned compared against 0")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>> ---
>>  drivers/pinctrl/pinctrl-rzn1.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-rzn1.c b/drivers/pinctrl/pinctrl-rzn1.c
>> index ce05e3a..b5650d8 100644
>> --- a/drivers/pinctrl/pinctrl-rzn1.c
>> +++ b/drivers/pinctrl/pinctrl-rzn1.c
>> @@ -195,7 +195,7 @@ static void rzn1_hw_set_lock(struct rzn1_pinctrl *ipctl, u8 lock, u8 value)
>>  static void rzn1_pinctrl_mdio_select(struct rzn1_pinctrl *ipctl, int mdio,
>>                                      u32 func)
>>  {
>> -       if (ipctl->mdio_func[mdio] >= 0 && ipctl->mdio_func[mdio] != func)
>> +       if (ipctl->mdio_func[mdio] != func)
>>                 dev_warn(ipctl->dev, "conflicting setting for mdio%d!\n", mdio);
>>         ipctl->mdio_func[mdio] = func;
>>
>> --
>> 2.7.4
>>