Re: [PATCH] gpio: Ignore gpio names with empty strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 4, 2018 at 10:18 PM Brandon Maier
<brandon.maier@xxxxxxxxxxxxxxxxxxx> wrote:

> If a gpiochip sets it's gpio_chip->names, it must give every gpio a
> unique name. However we may not need to name all gpios, for example if
> they are unused. gpio-line-names allows this by ignoring gpios with
> empty names. But gpiochip_set_desc_names() will yell at us, as the empty
> name will collide with other empty names. Fix this by skipping empty
> strings, so that they look like unnamed gpios.
>
> Signed-off-by: Brandon Maier <brandon.maier@xxxxxxxxxxxxxxxxxxx>

Isn't the real problem that they should be passing NULL
rather than "" empty string for line names?

Yours,
Linus Walleij



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux