Re: [PATCH 3/3] pinctrl: mcp23s08: rename to mcp23x08

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/09/2018 10:56 PM, Marco Felsch wrote:
This cosmetic patch replaces the 's' by a 'x', since the 's' is a
indication for SPI devices. Furthermore the datasheet refers to mcp23x08
too.


This breaks general kernel naming convention. Drivers are generally named after the
first chip they support.
And will cause everyone to have to update their kernel config for no benefit IMO.


Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
---
  drivers/pinctrl/Kconfig                                    | 2 +-
  drivers/pinctrl/Makefile                                   | 2 +-
  drivers/pinctrl/{pinctrl-mcp23s08.c => pinctrl-mcp23x08.c} | 0
  3 files changed, 2 insertions(+), 2 deletions(-)
  rename drivers/pinctrl/{pinctrl-mcp23s08.c => pinctrl-mcp23x08.c} (100%)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index e86752be1f19..1f312f479eb4 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -151,7 +151,7 @@ config PINCTRL_GEMINI
  	select GENERIC_PINCONF
  	select MFD_SYSCON
-config PINCTRL_MCP23S08
+config PINCTRL_MCP23X08
  	tristate "Microchip MCP23xxx I/O expander"
  	depends on SPI_MASTER || I2C
  	depends on I2C || I2C=n
diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
index 46ef9bd52096..036c34f7d099 100644
--- a/drivers/pinctrl/Makefile
+++ b/drivers/pinctrl/Makefile
@@ -19,7 +19,7 @@ obj-$(CONFIG_PINCTRL_DIGICOLOR)	+= pinctrl-digicolor.o
  obj-$(CONFIG_PINCTRL_FALCON)	+= pinctrl-falcon.o
  obj-$(CONFIG_PINCTRL_GEMINI)	+= pinctrl-gemini.o
  obj-$(CONFIG_PINCTRL_MAX77620)	+= pinctrl-max77620.o
-obj-$(CONFIG_PINCTRL_MCP23S08)	+= pinctrl-mcp23s08.o
+obj-$(CONFIG_PINCTRL_MCP23X08)	+= pinctrl-mcp23x08.o
  obj-$(CONFIG_PINCTRL_MESON)	+= meson/
  obj-$(CONFIG_PINCTRL_OXNAS)	+= pinctrl-oxnas.o
  obj-$(CONFIG_PINCTRL_PALMAS)	+= pinctrl-palmas.o
diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23x08.c
similarity index 100%
rename from drivers/pinctrl/pinctrl-mcp23s08.c
rename to drivers/pinctrl/pinctrl-mcp23x08.c



--
Regards
Phil Reid




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux