On Wed, Sep 19, 2018 at 6:48 PM YueHaibing <yuehaibing@xxxxxxxxxx> wrote: > 'ret' should be returned while pmic_mpp_write_mode_ctl fails. > > Fixes: 0e948042c420 ("pinctrl: qcom: spmi-mpp: Implement support for sink mode") > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> Patch applied. Yours, Linus Walleij