On Tue, Sep 18, 2018 at 03:14:44PM -0700, Rajat Jain wrote: > Also consider fixing the checkpatch warning: > > Errors: > * checkpatch.pl errors/warnings > > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > #48: FILE: drivers/pinctrl/intel/pinctrl-intel.c:764: > +static int intel_gpio_to_pin(struct intel_pinctrl *pctrl, > unsigned offset, Right, it is currently the "convention" used in Intel pinctrl drivers so I did not want to change that single entry. We should eventually convert the whole set of Intel pinctrl drivers to use unsigned int instead of unsigned.
Re: [PATCH] pinctrl: intel: Do pin translation in other GPIO operations as well
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] pinctrl: intel: Do pin translation in other GPIO operations as well
- From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
- Date: Wed, 19 Sep 2018 11:40:02 +0300
- In-reply-to: <CACK8Z6GfeJQSMN=m9hrFE2DFwpCNjNb57PqGiXFDD19Y=SXgnQ@mail.gmail.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20180918153621.71984-1-mika.westerberg@linux.intel.com> <CACK8Z6F4+N1paQTSWcomnwLpLEHoospSOT3M9bqFQZHHfWmahA@mail.gmail.com> <CACK8Z6GfeJQSMN=m9hrFE2DFwpCNjNb57PqGiXFDD19Y=SXgnQ@mail.gmail.com>
- User-agent: Mutt/1.10.1 (2018-07-13)
- Follow-Ups:
- References:
- Prev by Date: Re: [PATCH] pinctrl: intel: Do pin translation in other GPIO operations as well
- Next by Date: Re: [PATCH 2/2] pinctrl: sh-pfc: r8a77990: Add R8A774C0 PFC support
- Previous by thread: Re: [PATCH] pinctrl: intel: Do pin translation in other GPIO operations as well
- Next by thread: Re: [PATCH] pinctrl: intel: Do pin translation in other GPIO operations as well
- Index(es):
 |