Re: [PATCHv2,4/6] gpiolib: override irq_enable/disable

[Guenter Roeck <linux@xxxxxxxxxxxx>]

Hi,

On Sat, Sep 08, 2018 at 11:23:17AM +0200, Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> 
> When using the gpiolib irqchip helpers install irq_enable/disable
> hooks for the irqchip to ensure that gpiolib knows when the irq
> is enabled or disabled, allowing drivers to disable the irq and then
> use it as an output pin, and later switch the direction to input and
> re-enable the irq.
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>

This patch is causing a number of boot failures with qemu tests in
-next. A non-exhaustive list is:

arm:realview-pb-a8:realview_defconfig:arm-realview-pba8
arm:realview-pbx-a9:realview_defconfig:arm-realview-pbx-a9
arm:realview-eb:realview_defconfig:arm-realview-eb

"non-exhaustive" because most of my tests crash due to the recent
filesystem changes, and it is difficult to dig through 200+ boot
failures to identify other crash reasons.

Reverting the patch fixes the problem.

Guenter

---
# bad: [f8dcd02792146c5047419ff4c856651acd04f7c6] Add linux-next specific files for 20180913
# good: [11da3a7f84f19c26da6f86af878298694ede0804] Linux 4.19-rc3
git bisect start 'next-20180913' 'v4.19-rc3'
# good: [55628d01c950e01d5623a0d18a55ef85ac44a1f0] Merge remote-tracking branch 'crypto/master'
git bisect good 55628d01c950e01d5623a0d18a55ef85ac44a1f0
# good: [6cbddf4086a81886d25a0802a66632a6ca171273] Merge remote-tracking branch 'tip/auto-latest'
git bisect good 6cbddf4086a81886d25a0802a66632a6ca171273
# good: [5459d49aee6159b83ef4d4a985fd01893b75443b] Merge remote-tracking branch 'staging/staging-next'
git bisect good 5459d49aee6159b83ef4d4a985fd01893b75443b
# bad: [c80105cfc90216d6e5bbfc07ab64e732507142c3] Merge remote-tracking branch 'kselftest/next'
git bisect bad c80105cfc90216d6e5bbfc07ab64e732507142c3
# good: [84d3a3806fdb0ac6154a5fa5681b9ea67bf37581] Merge remote-tracking branch 'scsi/for-next'
git bisect good 84d3a3806fdb0ac6154a5fa5681b9ea67bf37581
# bad: [461c1a7d4733d1dfd5c47b040cf32a5e7eefbc6c] gpiolib: override irq_enable/disable
git bisect bad 461c1a7d4733d1dfd5c47b040cf32a5e7eefbc6c
# good: [888263947cd9f14e3f83be5b3e73ccabb71834d1] Merge branch 'ib-ingenic' of ../linux-pinctrl into devel
git bisect good 888263947cd9f14e3f83be5b3e73ccabb71834d1
# good: [ba21d55f6ad19cbb466b2429829900de5efac513] gpio: twl4030: Include the right header
git bisect good ba21d55f6ad19cbb466b2429829900de5efac513
# good: [ba74bd5d5b5b063d50891af16d5c14c29bcc52a6] gpio: twl6040: Implement .get_direction()
git bisect good ba74bd5d5b5b063d50891af16d5c14c29bcc52a6
# good: [f6d9af4770995d1f58be57139bce7974868231e8] gpio: ep93xx: fix test for end of loop
git bisect good f6d9af4770995d1f58be57139bce7974868231e8
# good: [ca620f2de153d690d6d6f50f32b8a14dd46107f4] gliolib: set hooks in gpiochip_set_irq_hooks()
git bisect good ca620f2de153d690d6d6f50f32b8a14dd46107f4
# good: [4e9439ddacea06f35acce4d374bf6bd0acf99bc8] gpiolib: add flag to indicate if the irq is disabled
git bisect good 4e9439ddacea06f35acce4d374bf6bd0acf99bc8
# first bad commit: [461c1a7d4733d1dfd5c47b040cf32a5e7eefbc6c] gpiolib: override irq_enable/disable