On 09/05/18 12:33, Linus Walleij wrote: > On Fri, Aug 31, 2018 at 4:37 PM Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > >> From: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> >> Since this driver does not use the gpiolib irqchip helpers it will have to >> allocate the irq resources and irq_en/disable itself. >> >> Use the new gpiochip_req/relres_irq helpers to request/release all the >> resources. >> >> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > This is just beautiful and makes everything so much easier. > > I have an urge to simply apply the patch set, it will make > Lina's work cleaner and easier too. Well, let me post this as a non-RFC and if you want to merge it, then who am I to object? :-) Regards, Hans