Re: [PATCH v1 7/9] pinctrl: cherryview: Describe members of couple of structs

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, Sep 05, 2018 at 10:19:19AM +0300, Mika Westerberg wrote:
> On Tue, Sep 04, 2018 at 02:26:23PM +0300, Andy Shevchenko wrote:
> > Compiler unsatisfied to see half described data structures
>   ^^^^^^^^
> 
> Are you sure the compiler even sees the comments? AFAIK preprocessor
> removes them before the compiler is run. Maybe these come from sparse or
> some other tool instead?

kernel-doc prints a message very like similar to what usually compiler produces.
Should I resend this, or, Linus, you can change this when applying?

> 
> > and issues warnings:
> > 
> > drivers/pinctrl/intel/pinctrl-cherryview.c:136: warning: Function parameter or member 'acpi_space_id' not described in 'chv_community'
> > drivers/pinctrl/intel/pinctrl-cherryview.c:169: warning: Function parameter or member 'saved_intmask' not described in 'chv_pinctrl'
> > drivers/pinctrl/intel/pinctrl-cherryview.c:169: warning: Function parameter or member 'saved_pin_context' not described in 'chv_pinctrl'

-- 
With Best Regards,
Andy Shevchenko