Re: [PATCH] pinctrl: Convert to using %pOFn instead of device_node.name

[Patrice CHOTARD <patrice.chotard@xxxxxx>]

Hi Rob

On 08/28/2018 03:52 AM, Rob Herring wrote:
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
> 
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Dong Aisheng <aisheng.dong@xxxxxxx>
> Cc: Fabio Estevam <festevam@xxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: Stefan Agner <stefan@xxxxxxxx>
> Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> Cc: Sean Wang <sean.wang@xxxxxxxxxxxx>
> Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> Cc: Carlo Caione <carlo@xxxxxxxxxx>
> Cc: Kevin Hilman <khilman@xxxxxxxxxxxx>
> Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
> Cc: Andrew Lunn <andrew@xxxxxxx>
> Cc: Gregory Clement <gregory.clement@xxxxxxxxxxx>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>
> Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Cc: Haojian Zhuang <haojian.zhuang@xxxxxxxxxx>
> Cc: Patrice Chotard <patrice.chotard@xxxxxx>
> Cc: Barry Song <baohua@xxxxxxxxxx>
> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxx>
> Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>
> Cc: Chen-Yu Tsai <wens@xxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Cc: linux-mediatek@xxxxxxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-amlogic@xxxxxxxxxxxxxxxxxxx
> Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>   drivers/pinctrl/berlin/berlin.c               |  6 ++--
>   drivers/pinctrl/freescale/pinctrl-imx.c       |  7 ++--
>   drivers/pinctrl/freescale/pinctrl-imx1-core.c | 12 +++----
>   drivers/pinctrl/mediatek/pinctrl-mtk-common.c |  4 +--
>   drivers/pinctrl/meson/pinctrl-meson.c         |  2 +-
>   drivers/pinctrl/mvebu/pinctrl-mvebu.c         |  4 +--
>   drivers/pinctrl/nomadik/pinctrl-nomadik.c     |  6 ++--
>   drivers/pinctrl/pinctrl-at91.c                |  8 ++---
>   drivers/pinctrl/pinctrl-lantiq.c              |  8 ++---
>   drivers/pinctrl/pinctrl-rockchip.c            |  8 ++---
>   drivers/pinctrl/pinctrl-rza1.c                |  8 ++---
>   drivers/pinctrl/pinctrl-single.c              | 32 +++++++++----------
>   drivers/pinctrl/pinctrl-st.c                  |  6 ++--
>   drivers/pinctrl/sirf/pinctrl-atlas7.c         |  4 +--
>   drivers/pinctrl/stm32/pinctrl-stm32.c         |  4 +--
>   drivers/pinctrl/sunxi/pinctrl-sunxi.c         |  8 ++---
>   drivers/pinctrl/ti/pinctrl-ti-iodelay.c       |  8 ++---
>   17 files changed, 66 insertions(+), 69 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 0966bb0bf71f..e66af93f2cbf 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -817,8 +817,8 @@ static int st_pctl_dt_node_to_map(struct pinctrl_dev *pctldev,
>   
>   	grp = st_pctl_find_group_by_name(info, np->name);
>   	if (!grp) {
> -		dev_err(info->dev, "unable to find group for node %s\n",
> -			np->name);
> +		dev_err(info->dev, "unable to find group for node %pOFn\n",
> +			np);
>   		return -EINVAL;
>   	}
>   
> @@ -1184,7 +1184,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
>   		if (pp->length / sizeof(__be32) >= OF_GPIO_ARGS_MIN) {
>   			npins++;
>   		} else {
> -			pr_warn("Invalid st,pins in %s node\n", np->name);
> +			pr_warn("Invalid st,pins in %pOFn node\n", np);
>   			return -EINVAL;
>   		}
>   	}

For pinctrl-st:

Acked-by: Patrice Chotard <patrice.chotard@xxxxxx>

Thanks
Patrice