Re: [PATCH v1 2/7] pinctrl: intel: Introduce intel_pinctrl_get_soc_data() internal API

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Mon, Aug 20, 2018 at 07:17:07PM +0300, Mika Westerberg wrote:
> On Mon, Aug 20, 2018 at 05:46:42PM +0300, Andy Shevchenko wrote:
> > On Mon, 2018-08-20 at 17:09 +0300, Mika Westerberg wrote:
> > > On Mon, Aug 20, 2018 at 04:35:08PM +0300, Andy Shevchenko wrote:
> > > > +int intel_pinctrl_get_soc_data(struct platform_device *pdev,
> > > > +			       const struct intel_pinctrl_soc_data
> > > > **soc_data);
> > > >  int intel_pinctrl_probe(struct platform_device *pdev,
> > > >  			const struct intel_pinctrl_soc_data *soc_data);
> > > 
> > > Can we make intel_pinctrl_probe() to handle this instead?
> > 
> > I'm not sure. There are basically two different ways how we get SoC
> > data. For now, we have two (*) drivers that are using _UID, otherwise
> > device_get_match_data() pretty much covers everything else.
> 
> Hmm, then maybe have two probe functions where one deals with _UID
> and the other handles the rest?

Yes, I agree. Let's leave intel_pinctrl_probe() for the cases when one ID per
one community and introduce intel_pinctrl_probe_many() for the rest.

Thanks for review!

-- 
With Best Regards,
Andy Shevchenko