Re: [PATCH] gpio: tb10x: Use the right include

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Christian Ruppert <christian.ruppert@xxxxxxxxxxx>

On 06.08.2018 16:23, Linus Walleij wrote:
> This driver includes the legacy <linux/gpio.h> and
> <linux/of_gpio.h> but all it needs is really <linux/gpio/driver.h>.
> 
> Cc: linux-snps-arc@xxxxxxxxxxxxxxxxxxx
> Cc: Christian Ruppert <christian.ruppert@xxxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
>  drivers/gpio/gpio-tb10x.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
> index ac6f2a9841e5..a12cd0b5c972 100644
> --- a/drivers/gpio/gpio-tb10x.c
> +++ b/drivers/gpio/gpio-tb10x.c
> @@ -22,7 +22,7 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
>  #include <linux/slab.h>
>  #include <linux/irq.h>
>  #include <linux/irqdomain.h>
> @@ -30,7 +30,6 @@
>  #include <linux/io.h>
>  #include <linux/of.h>
>  #include <linux/of_platform.h>
> -#include <linux/of_gpio.h>
>  #include <linux/spinlock.h>
>  #include <linux/bitops.h>
>  #include <linux/pinctrl/consumer.h>
> 




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux