Hello Linus, I have sent modified patch for this bag as v2. Please refer to the following. [PATCH v2] https://patchwork.kernel.org/patch/10533929/ [Changes since v1] diff --git a/drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.c b/drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.c -index 0f921a6..f912999 100644 +index 0f921a6..f086083 100644 --- a/drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.c +++ b/drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.c @@ -504,6 +504,8 @@ static const unsigned nand_cs1_pins[] = {22, 23}; @@ -390,7 +393,7 @@ static const char * const i2c3_groups[] = {"i2c3"}; static const char * const nand_groups[] = {"nand", "nand_cs1"}; static const char * const sd_groups[] = {"sd"}; -+static const char * const spi_groups[] = {"spi0"}; ++static const char * const spi0_groups[] = {"spi0"}; static const char * const system_bus_groups[] = {"system_bus", "system_bus_cs1", "system_bus_cs2", I mistook "spi0_groups" with " spi_groups", so there was an undeclared error. ----------------- Best Regards, Keiji Hayashibara > -----Original Message----- > From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx] > Sent: Monday, July 30, 2018 5:47 AM > To: Hayashibara, Keiji/林原 啓二 <hayashibara.keiji@xxxxxxxxxxxxx> > Cc: Yamada, Masahiro/山田 真弘 <yamada.masahiro@xxxxxxxxxxxxx>; open list:GPIO SUBSYSTEM > <linux-gpio@xxxxxxxxxxxxxxx>; Linux ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; Masami Hiramatsu > <masami.hiramatsu@xxxxxxxxxx>; Jassi Brar <jaswinder.singh@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Hayashi, > Kunihiko/林 邦彦 <hayashi.kunihiko@xxxxxxxxxxxxx> > Subject: Re: [PATCH] pinctrl: uniphier: add spi pin-mux settings > > On Thu, Jul 19, 2018 at 8:21 AM Keiji Hayashibara <hayashibara.keiji@xxxxxxxxxxxxx> wrote: > > > From: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx> > > > > Add pin-mux settings for spi controller. > > > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx> > > Signed-off-by: Keiji Hayashibara <hayashibara.keiji@xxxxxxxxxxxxx> > > There is some problem with the test robot, can you comment/followup? > > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html