On 19.07.2018 10:16, Dan Carpenter wrote: > The > should really be >= here. It's harmless because > pinctrl_generic_get_group() will return a NULL if group is invalid. > > Fixes: ae75ff814538 ("pinctrl: pinctrl-imx: add imx pinctrl core driver") > Reported-by: Dong Aisheng <aisheng.dong@xxxxxxx> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Reviewed-by: Stefan Agner <stefan@xxxxxxxx> > --- > > diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c > b/drivers/pinctrl/freescale/pinctrl-imx.c > index 1c6bb15579e1..b04edc22dad7 100644 > --- a/drivers/pinctrl/freescale/pinctrl-imx.c > +++ b/drivers/pinctrl/freescale/pinctrl-imx.c > @@ -383,7 +383,7 @@ static void imx_pinconf_group_dbg_show(struct > pinctrl_dev *pctldev, > const char *name; > int i, ret; > > - if (group > pctldev->num_groups) > + if (group >= pctldev->num_groups) > return; > > seq_puts(s, "\n"); -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html