Re: [PATCH 12/22] gpio: xilinx: Add support to set multiple GPIO at once

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Sat, Jul 21, 2018 at 4:28 PM Hedges Alexander
<ahedges@xxxxxxxxxxxxxxx> wrote:

> From: Iban Rodriguez <irodriguez@xxxxxxxxxxx>
> Date: Fri, 13 May 2016 12:11:46 +0200
>
> Add function to set multiple GPIO of the same chip at the same time
> and register it.
>
> Signed-off-by: Iban Rodriguez <irodriguez@xxxxxxxxxxx>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> Signed-off-by: Alexander Hedges <ahedges@xxxxxxx>
> (cherry picked from commit 63bcc8b82965b185e632170dca04185539d970f9)

Instead of this I think it is better to switch the whole driver
over to just use GPIO_GENERIC, see for example how
we implement drivers/gpio/gpio-ftgpio010.c.

If you select GPIO_GENERIC and use bgpio_init()
to set up the affected registers, the GPIO_GENERIC
code will implement and supply get/set_multiple()
callbacks that are widely tested and deployed with
other platforms already.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html