Re: [PATCH 1/1] Merge xilinx gpio driver from linux-xlnx

[Michal Simek <michal.simek@xxxxxxxxxx>]

On 19.7.2018 17:22, Hedges  Alexander wrote:
> This updates gpio-xilinx to include all the commits which are only present in
> the official Xilinx Linux repository (github.com/Xilinx/linux-xlnx). The last
> common ancestor is 64842aad5ec5, after that, linux-xlnx has not been merged into
> mainline linux.
> 
> The only thing added in the merge is the second lock_class_key which is needed
> by irq_set_lockdep_class after the signature change in 39c3fd58952d.
> 
> The changes to gpio-xilinx.c from the following commits are included:
> 
> commit 184f4682479b34d279d8fec236126b7e2f6a94ce
> Author: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> Date: Thu May 3 14:35:46 2018 +0530
> Title: gpio: xilinx: Add support for no initialisation at probe
> 
> commit dbf204e7a104cd1bb5eeaec945811c986bed4840
> Author: Swapna Manupati <swapna.manupati@xxxxxxxxxx>
> Date: Wed Mar 7 17:03:19 2018 +0530
> Title: gpio: xilinx: Add reset support
> 
> commit 3bbc2fda8018d067910eac153c1f30caa509828a
> Author: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@xxxxxxxxxx>
> Date: Wed Jan 24 18:20:19 2018 +0530
> Title: gpio: xilinx: defer the probe if clock is not found
> 
> commit 1bd0377e19ba07436d1430f444f701c97e9cefd1
> Author: Michal Simek <michal.simek@xxxxxxxxxx>
> Date: Mon Oct 16 10:30:20 2017 +0200
> Title: gpio: Fix typo in gpio driver
> 
> commit 3da7287a068080a6e100ddfef449ab94bebd429d
> Author: Nava kishore Manne <nava.manne@xxxxxxxxxx>
> Date: Wed Apr 19 17:41:20 2017 +0530
> Title: gpio: gpio-xilinx: Fix warnings in the driver
> 
> commit 24132f85de16dd69948ed1fd1cd6bfef3802e9bd
> Author: Nava kishore Manne <nava.manne@xxxxxxxxxx>
> Date: Wed Apr 19 14:54:20 2017 +0530
> Title: gpio: gpio-xilinx.c: Fix kernel doc warnings
> 
> commit 30b6bc689ae71b657f5e1f7fb86468b9d8edcfc2
> Author: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> Date: Thu Apr 6 16:12:00 2017 +0530
> Title: gpio: xilinx: Fix the NULL pointer access
> 
> commit e469c51aeca082452d0d34897f713906f4d3599a
> Author: Michal Simek <michal.simek@xxxxxxxxxx>
> Date: Tue Feb 14 16:16:56 2017 +0100
> Title: gpio: Add simple remove and exit functions
> 
> commit 34b6b71b142476b9e377f2e21b087eb8434176cd
> Author: Maulik Jodhani <maulik.jodhani@xxxxxxxxxx>
> Date: Fri Feb 10 06:31:30 2017 -0800
> Title: gpio: xilinx: Add clock adaptation support
> 
> commit c8105d8066c1b9ba5f8e160c213c7605ba6dffab
> Author: Michal Simek <michal.simek@xxxxxxxxxx>
> Date: Thu Jul 28 14:59:50 2016 +0200
> Title: gpio: xilinx: Use readl/writel for ARM64
> 
> commit 1c9c40cbcbd896a6ee35e46560b5c3e99718c620
> Author: Iban Rodriguez <irodriguez@xxxxxxxxxxx>
> Date: Mon Jun 13 12:53:39 2016 +0200
> Title: gpio: xilinx: Always use own xlate function
> 
> commit 63bcc8b82965b185e632170dca04185539d970f9
> Author: Iban Rodriguez <irodriguez@xxxxxxxxxxx>
> Date: Fri May 13 12:11:46 2016 +0200
> Title: gpio: xilinx: Add support to set multiple GPIO at once
> 
> commit 426ad456b920a9b26394b1f973c100cf3984b954
> Author: Topi Kuutela <topi.kuutela@xxxxxxxxx>
> Date: Wed May 11 14:53:41 2016 +0300
> Title: gpio: xilinx: Fix irq-handler prototype
> 
> commit 4fdaf2960d8ccecb504d312d2f7b2d532941a8dd
> Author: Michal Simek <michal.simek@xxxxxxxxxx>
> Date: Wed Jun 17 06:44:12 2015 +0200
> Title: xilinx: Remove owner field from platform_driver
> 
> commit 616ac116ab2dcfe603c67ea3c8f70d5889aa6fc9
> Author: Michal Simek <michal.simek@xxxxxxxxxx>
> Date: Tue Sep 3 17:06:19 2013 +0200
> Title: gpio: xilinx: Use platform_driver
> 
> commit 5f35773def8d97fcc48c587f54439ca12fc6a601
> Author: Michal Simek <michal.simek@xxxxxxxxxx>
> Date: Tue Sep 3 16:43:47 2013 +0200
> Title: gpio: xilinx: Fix minor coding style issue.
> 
> commit 32161b344f3eb80f59bd99e9ca215a93b40b929a
> Author: Michal Simek <michal.simek@xxxxxxxxxx>
> Date: Tue Sep 3 16:22:12 2013 +0200
> Title: gpio: xilinx: Fix type for irq_base
> 
> commit 9a5d02ee0f4fc8f7ff461e8955eaed19e542bed8
> Author: Michal Simek <michal.simek@xxxxxxxxxx>
> Date: Tue Aug 6 13:59:47 2013 +0200
> Title: GPIO: xilinx: Do not use xgpiops but use only xgpio
> 
> commit 7c58460d5bb43758d879f391e85b7b857160d488
> Author: Michal Simek <michal.simek@xxxxxxxxxx>
> Date: Tue Aug 6 13:16:36 2013 +0200
> Title: GPIO: xilinx: Do not allocate interrupts for IPs without IRQ support
> 
> commit 796ae5e3e4ae5f550e0ba01ade34604c83b08cfd
> Author: Michal Simek <michal.simek@xxxxxxxxxx>
> Date: Fri Jul 19 14:34:36 2013 +0200
> Title: GPIO: xilinx: Add irq support to the driver
> 
> commit 8fd1942dec9edd0175dc6f242a9ab8c663c07fb9
> Author: Michal Simek <michal.simek@xxxxxxxxxx>
> Date: Fri Jul 19 14:31:15 2013 +0200
> Title: GPIO: xilinx: Fix kernel-doc mainline
> 
> commit 6ecc02b189fb0147dd3221ff347f42901c575927
> Author: Michal Simek <michal.simek@xxxxxxxxxx>
> Date: Wed Jul 17 15:22:20 2013 +0200
> Title: GPIO: xilinx: Use standard coding style for macros
> 
> commit 324c11445a487744dd2e4c286b63e83fc18eae54
> Author: Michal Simek <michal.simek@xxxxxxxxxx>
> Date: Tue Nov 27 15:40:47 2012 +0100
> Title: gpio: gpio-xilinx: Remove CONFIG_OF conditionals
> 
> commit fb2379e7035e9855543e49637828aca4b7e72f58
> Author: Michal Simek <monstr@xxxxxxxxx>
> Date: Fri Oct 19 10:49:31 2012 +0200
> Title: of: gpio: Add support for dual xilinx GPIO
> 
> commit 5a711f8ecdc69bdf6a23494a503dd6f3c39381ce
> Author: Naveen Mamindlapalli <naveenm@xxxxxxxxxx>
> Date: Fri Aug 31 20:11:29 2012 +0530
> Title: Xilinx: Microblaze: GPIO: Fixed compilation error.
> 
> commit e9a98626baf3b31fa6a699576d8d089c5df10f35
> Author: John Linn <john.linn@xxxxxxxxxx>
> Date: Fri Jun 29 11:27:45 2012 -0700
> Title: Xilinx: ARM: GPIO: updated driver names for cleanup
> 
> From: Xilinx
> Co-authored-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> Co-authored-by: Swapna Manupati <swapna.manupati@xxxxxxxxxx>
> Co-authored-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@xxxxxxxxxx>
> Co-authored-by: Nava kishore Manne <nava.manne@xxxxxxxxxx>
> Co-authored-by: Maulik Jodhani <maulik.jodhani@xxxxxxxxxx>
> Co-authored-by: Iban Rodriguez <irodriguez@xxxxxxxxxxx>
> Co-authored-by: Topi Kuutela <topi.kuutela@xxxxxxxxx>
> Co-authored-by: Michal Simek <michal.simek@xxxxxxxxxx>
> Co-authored-by: Naveen Mamindlapalli <naveenm@xxxxxxxxxx>
> Co-authored-by: John Linn <john.linn@xxxxxxxxxx>
> Signed-off-by: Alexander Hedges <ahedges@xxxxxxx>
> 
> ---
> 
> A bit of explanation:
> 
> While linux-xlnx has has never been merged into linux, the opposite happened
> quite often. So deconstructing the changes since 2011 and applying them onto
> 4.17 one-by-one in a way that does not break the builds and where the result
> is the same as the current head of linux-xlnx + the patch for
> irq_set_lockdep_class seems like a nearly impossible task to me.
> 
> Note that this is my first email to the kernel mailing list, so if I'm doing
> something fundamentally wrong, please tell me. Also, I don't know how
> changes like these are usually handled, if there is a better way to have the
> newest version of gpio-xilinx in mainline linux, let me know.
> 
> I'm not affiliated with Xilinx in any way.

NACK.
That's not the way to go. You can cherry-pick that patches with keeping
origin author name and send them out but you can't squash all stuff
together. Please look at submitting patches doc in documentation for the
rules you need to follow.

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html