Re: [PATCH v2] gpiolib-acpi: make sure we trigger edge events at least once on boot

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Fri, 2018-07-13 at 17:52 +0200, Benjamin Tissoires wrote:
> On Fri, Jul 13, 2018 at 10:13 AM Benjamin Tissoires
> <benjamin.tissoires@xxxxxxxxxx> wrote:
> > On Thu, Jul 12, 2018 at 6:23 PM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > On Thu, 2018-07-12 at 17:25 +0200, Hans de Goede wrote:

> > > Benjamin, for sake of testing is it possible to revert (temporary)
> > > the
> > > change you mentioned for _LID and test if this helps as well as
> > > stated?
> > 
> > I'll try to do it today, but I can't guarantee if it will be done
> > today. IIRC, I have been told that the Surface 3 was having
> > difficulties with recent kernels, so crossing fingers here.
> > 
> 
> after a lot of efforts, I confirm that the latest version from Hans
> fixes the suspend loop issue without surface3_wmi.
> I had to test the patch on a v4.16 kernel as the v4.18 doesn't boot
> (the i915 complains about not being able to drive the DSI, the
> backlight complains in the same way, and lots of new ACPI errors are
> appearing related to the GPU nodes).
> 
> I just checked, and surface3_wmi has another capability: it helps
> setting up the touchscreen/stylus when the tablet is booted with the
> cover closed. So maybe we should be able to strip out the LID part of
> surface3_wmi, but we should keep the rest anyway.
> 
> One last thing, this patch also enable the charging capability of the
> tablet. With a kernel that doesn't have it, but which has the MSHW0011
> driver I reversed engineer, the ADP will be marked as plugged in, but
> the tablet won't charge (and the battery will not be marked as
> charging). With it, everything goes back to normal :)

Very nice!

Thanks a lot for confirming!

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html