Re: [PATCH] gpio: pxa: make controllers without pinctrl work again

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, July 02, 2018 09:28 AM, Tony Lindgren wrote:
* Linus Walleij <linus.walleij@xxxxxxxxxx> [180629 12:52]:
On Sun, Jun 24, 2018 at 11:27 PM Daniel Mack <daniel@xxxxxxxxxx> wrote:

To recap, the pxa3xx driver uses the pinctrl-single driver since a while
which does not implement a .gpio_set_direction() callback. The pinmux
core will simply return 0 in this case, and the pxa3xx gpio driver hence
thinks the pinctrl driver did its job and returns as well.

I guess we need to discuss with Tony and Haojian if pinctrl-single should
ever implement that or if it is thought as having GPIO and pin
control orthogonally.

Sure why not as long as pinctrl-single can decipher the gpio
number and then call the GPIO framework.

Hmm, but the call is coming from the GPIO framework already. I'm not quite following.

Anyway. it seems that teaching the pinctrl-single driver needs to learn setting directions at all, so for now, I'd like to get the patch that works around that merged for 4.19. I'll reword the commit log a bit and resend.


Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux