Re: [PATCH v4 1/2] gpio: mediatek: add driver for MT7621

[Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>]

On Mon, Jul 09, 2018 at 01:45:22PM +0200, Linus Walleij wrote:
> On Thu, Jul 5, 2018 at 3:43 PM Sergio Paracuellos
> <sergio.paracuellos@xxxxxxxxx> wrote:
> 
> > Add driver support for gpio of MT7621 SoC.
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> > Reviewed-by: NeilBrown <neil@xxxxxxxxxx>
> 
> This is looking really good.
> 
> Patch applied: anything remaining can surely be patched up
> in-tree.
>

Sound good, thanks.

Should I send a patch to remove the driver from staging or just
is removed by Greg? How is this achieved?
 
> > +/*
> > + * Copyright (C) 2009-2011 Gabor Juhos <juhosg@xxxxxxxxxxx>
> > + * Copyright (C) 2013 John Crispin <blogic@xxxxxxxxxxx>
> > + */
> 
> All OpenWRT drivers are moving upstream and I like it :)
> Gabo and John wrote like 90% of them on their own :D
> 
> > +#define GPIO_BANK_WIDE 0x04
> 
> Nitpick: we usually call this "stride" rather than "wide".
> I changed it while applying the patch.

Thanks :-)

> 
> Yours,
> Linus Walleij

Best regards,
    Sergio Paracuellos
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html