Re: [PATCH] gpio: pca953x: suppress interrupts warning when not applicable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2018-06-29 at 11:11 +0200, Linus Walleij wrote:
> On Thu, Jun 21, 2018 at 3:38 PM Baruch Siach <baruch@xxxxxxxxxx>
> wrote:
> 
> > Don't warn about missing interrupts support when the parent
> > interrupt is
> > not defined. Enabling interrupts support would not make it work
> > anyway.
> > 
> > Signed-off-by: Baruch Siach <baruch@xxxxxxxxxx>
> 
> Would be great to get some review from Andy and/or H. Nikolaus before
> applying this patch.

If I read that patch correctly and the GPIO expander which _can_
generate interrupt has no INT line connected, the change makes sense to
me.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux