Re: [PATCH 4/4] pinctrl: mcp23s08: work around GPIO line naming

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Wed, Jun 13, 2018 at 11:07:00AM +0200, Linus Walleij wrote:
> > +                       devprop_gpiochip_set_names(&data->mcp[addr]->chip, of_fwnode_handle(np));
> 
> I'm not very happy about reaching into the gpiolib internal API like
> this.
> 
> As Phil says the function should be moved to <linux/gpio/driver.h>
> if we need to use it from drivers.
> 
> Also, this symbol is not exported so you would get compile errors
> from the test farm quickly becuase a lot of module building
> starts failing. This function needs EXPORT_SYMBOL_GPL()
> to be used from the outside in drivers.
> 
> Mika added this function, I don't know how he feels about
> having it externalized?

No objections from my side.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html