Re: [PATCH] Revert "pinctrl: devicetree: Fix dt_to_map_one_config handling of hogs"

[Fabio Estevam <festevam@xxxxxxxxx>]

Hi Richard,

On Thu, Jun 7, 2018 at 7:14 AM, Richard Fitzgerald
<rf@xxxxxxxxxxxxxxxxxxxxx> wrote:

> Have you determined why the iMX driver's hogs fail the check
> (np_pctldev == p->dev->of_node)? That would seem to be the reason

I applied the following change in the original 4.17 kernel:

--- a/drivers/pinctrl/devicetree.c
+++ b/drivers/pinctrl/devicetree.c
@@ -122,6 +122,11 @@ static int dt_to_map_one_config(struct pinctrl *p,
                        /* OK let's just assume this will appear later then */
                        return -EPROBE_DEFER;
                }
+
+               if (np_pctldev == p->dev->of_node)
+                       dev_info(p->dev, "***** Matched: %s\n",
p->dev->of_node->name);
+               else
+                       dev_info(p->dev, "***** Not Matched: %s\n",
p->dev->of_node->name);
                /* If we're creating a hog we can use the passed pctldev */
                if (pctldev && (np_pctldev == p->dev->of_node))
                        break;

and this is what I get:

[    0.082643] imx53-pinctrl 53fa8000.iomuxc: ***** Not Matched: iomuxc
[    0.082803] imx53-pinctrl 53fa8000.iomuxc: ***** Matched: iomuxc
[    0.084386] imx53-pinctrl 53fa8000.iomuxc: ***** Not Matched: iomuxc
[    0.084413] imx53-pinctrl 53fa8000.iomuxc: ***** Matched: iomuxc
[    0.155791] imx-i2c 63fc4000.i2c: ***** Not Matched: i2c
[    0.155828] imx-i2c 63fc4000.i2c: ***** Not Matched: i2c
[    0.158001] imx-i2c 63fc8000.i2c: ***** Not Matched: i2c
[    0.158033] imx-i2c 63fc8000.i2c: ***** Not Matched: i2c
[    0.159389] mc13xxx 0-0008: ***** Not Matched: mc34708
[    0.159440] mc13xxx 0-0008: ***** Not Matched: mc34708
[    0.247099] imx-audmux 63fd0000.audmux: ***** Not Matched: audmux
[    0.247130] imx-audmux 63fd0000.audmux: ***** Not Matched: audmux
[    0.340774] imx-uart 53fbc000.serial: ***** Not Matched: serial
[    0.340819] imx-uart 53fbc000.serial: ***** Not Matched: serial
[    1.189378] imx-tve 63ff0000.tve: ***** Not Matched: tve
[    1.194917] imx-tve 63ff0000.tve: ***** Not Matched: tve
[    1.485778] fec 63fec000.ethernet: ***** Not Matched: ethernet
[    1.491713] fec 63fec000.ethernet: ***** Not Matched: ethernet
[    1.746872] sdhci-esdhc-imx 50004000.esdhc: ***** Not Matched: esdhc
[    1.753489] sdhci-esdhc-imx 50004000.esdhc: ***** Not Matched: esdhc
[    1.818500] sdhci-esdhc-imx 50020000.esdhc: ***** Not Matched: esdhc
[    1.825480] sdhci-esdhc-imx 50020000.esdhc: ***** Not Matched: esdhc
[    1.883043] leds-gpio leds: ***** Not Matched: leds
[    1.887976] leds-gpio leds: ***** Not Matched: leds


I am running imx53-qdb.dtb which includes
arch/arm/boot/dts/imx53-qsb-common.dtsi.

The pinctrl driver is drivers/pinctrl/freescale/pinctrl-imx53.c

Any ideas?
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html