Re: [PATCH] gpio: rcar: Add Runtime PM handling for interrupts

[Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>]

On Tue, May 22, 2018 at 05:58:15PM +0100, Fabrizio Castro wrote:
> From: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> commit b26a719bdba9aa926ceaadecc66e07623d2b8a53 upstream.
> 
> The R-Car GPIO driver handles Runtime PM for requested GPIOs only.
> 
> When using a GPIO purely as an interrupt source, no Runtime PM handling
> is done, and the GPIO module's clock may not be enabled.
> 
> To fix this:
>   - Add .irq_request_resources() and .irq_release_resources() callbacks
>     to handle Runtime PM when an interrupt is requested,
>   - Add irq_bus_lock() and sync_unlock() callbacks to handle Runtime PM
>     when e.g. disabling/enabling an interrupt, or configuring the
>     interrupt type.
> 
> Fixes: d5c3d84657db57bd "net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS"
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> [fabrizio: cherry-pick to v4.4.y. Use container_of instead of
> gpiochip_get_data.]
> Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> Reviewed-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> ---
> Hi Greg,
> 
> on R-Car we have found that if a GPIO is used purely as an interrupt source,
> the corresponding clock is not enabled, therefore the interrupt doesn't work.
> On Koelsch, the HDMI trasmitter node in the DT uses GPIO 3 29 for the
> interrupt line, and since gpio3 is used only for this, its clock is OFF,
> preventing the interrupt from working. This patch fixes this problem.
> Would you please consider this patch for 4.4.y?

Now applied, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html