Re: [PATCH 1/2] gpio: mxc: Switch to SPDX identifier

[Enric Balletbo Serra <eballetbo@xxxxxxxxx>]

Dear Fabio,

2018-05-22 4:32 GMT+02:00 Fabio Estevam <festevam@xxxxxxxxx>:
> From: Fabio Estevam <fabio.estevam@xxxxxxx>
>
> Adopt the SPDX license identifier headers to ease license compliance
> management.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
> ---
>  drivers/gpio/gpio-mxc.c | 29 ++++++++---------------------
>  1 file changed, 8 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index 11ec722..6a9dc61 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -1,24 +1,11 @@
> -/*
> - * MXC GPIO support. (c) 2008 Daniel Mack <daniel@xxxxxxxx>
> - * Copyright 2008 Juergen Beisert, kernel@xxxxxxxxxxxxxx
> - *
> - * Based on code from Freescale Semiconductor,
> - * Authors: Daniel Mack, Juergen Beisert.
> - * Copyright (C) 2004-2010 Freescale Semiconductor, Inc. All Rights Reserved.
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License
> - * as published by the Free Software Foundation; either version 2
> - * of the License, or (at your option) any later version.
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +//
> +// MXC GPIO support. (c) 2008 Daniel Mack <daniel@xxxxxxxx>
> +// Copyright 2008 Juergen Beisert, kernel@xxxxxxxxxxxxxx
> +//
> +// Based on code from Freescale Semiconductor,
> +// Authors: Daniel Mack, Juergen Beisert.
> +// Copyright (C) 2004-2010 Freescale Semiconductor, Inc. All Rights Reserved.
>

I think that the C++ style comment only applies to the license
identifier line. For the rest, you should continue using C style
comments.

// SPDX-License-Identifier: GPL-2.0+
/*
 * Copyright ...
 * Author ...
 */

Best regards,
 Enric

>  #include <linux/err.h>
>  #include <linux/init.h>
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html