Hi, Fabio Anson Huang Best Regards! > -----Original Message----- > From: Fabio Estevam [mailto:festevam@xxxxxxxxx] > Sent: Tuesday, May 22, 2018 10:28 AM > To: Anson Huang <anson.huang@xxxxxxx> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; > linux-gpio@xxxxxxxxxxxxxxx; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH V2] gpio: mxc: add clock operation > > Hi Anson, > > On Mon, May 21, 2018 at 10:15 PM, Anson Huang <Anson.Huang@xxxxxxx> > wrote: > > Some i.MX SoCs have GPIO clock gates in CCM CCGR, such as i.MX6SLL, > > need to enable clocks before accessing GPIO registers, add optional > > clock operation for GPIO driver. > > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > --- > > changes since V1: > > add missing clk header; > > remove FSF addresses in copyright to avoid check patch ERROR. > > drivers/gpio/gpio-mxc.c | 18 ++++++++++++++---- > > 1 file changed, 14 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c index > > 11ec722..2026f94 100644 > > --- a/drivers/gpio/gpio-mxc.c > > +++ b/drivers/gpio/gpio-mxc.c > > @@ -14,12 +14,9 @@ > > * but WITHOUT ANY WARRANTY; without even the implied warranty of > > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > * GNU General Public License for more details. > > - * > > - * You should have received a copy of the GNU General Public License > > - * along with this program; if not, write to the Free Software > > - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, > USA. > > */ > > This is an unrelated change and should be part of a different patch. > > A patch that converts this driver to use SPDX would get rid of the FSF address. Thanks, I will rework it into 2 patches, using SPDX. Anson. ��.n��������+%������w��{.n�����{�� b���ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f