Re: [PATCHv8] gpio: Remove VLA from gpiolib

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Sat, May 19, 2018 at 12:05 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Fri, May 18, 2018 at 10:07 PM, Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
>> On Fri, May 18, 2018 at 8:53 PM, Laura Abbott <labbott@xxxxxxxxxx> wrote:

>>> +               bits = mask + BITS_TO_LONGS(chip->ngpio);
>>> +               memset(mask, 0, BITS_TO_LONGS(chip->ngpio) * sizeof(*mask));
>>
>> Wouldn't be better
>>
>> bitmap_zero(mask, chip->ngpio);
>>
>> ?
>
> chip->ngpio is never const, so bitmap_zero() would always fall back to
> plain memset().

Yes. But it also much more readable and understandable here.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html