Re: [PATCH] pinctrl: rockchip: Add set_config callback support for gpiolib

[Heiko Stuebner <heiko@xxxxxxxxx>]

Am Donnerstag, 3. Mai 2018, 10:04:42 CEST schrieb Shawn Lin:
> Could only support PIN_CONFIG_INPUT_DEBOUNCE now as the HW block
> is too simple to support others. But even wrt. debounce capability,
> it now could only support very limited period of time to satisfy the
> real usecase. But still be useful to enable the crippled HW debounce
> to prevent any spurious glitches from waking up the system if the
> gpio is conguired as wakeup interrupt source.
> 
> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>

>From the argument given, this sounds sane to me, also about not changing
the behaviour (as noted in the comment in _set_config) and the code looks
also good to me, so from my non electrical pov

Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>


Heiko


--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html