Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v2] pinctrl: sh-pfc: Add r8a77470 PFC support > > Hi Biju, > > On Tue, Apr 24, 2018 at 1:03 PM, Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > > Add PFC support for the R8A77470 SoC including pin groups for some > > on-chip devices such as SCIF, AVB and MMC. > > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > > Thanks for your patch! > > > --- > > V1-->V2 > > * Incoroporated the following review comments > > * Fixed MOD_SEL to MOD_SEL0 > > * Created seperate pin group for AVB_COL and AVB_CRS > > * Added the pin group AVB_CAPTURE and AVB_MATCH > > * Added missing SCIF pin groups > > I believe this is v3, not v2? Yes it is v3, I have realised this after sending the patch. > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Given the (unfinished) discussion about the AVB pins, I'll apply and queue > your patch in sh-pfc-for-v4.18 with the AVB pin groups removed. It is ok for me. Regards, Biju Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ��.n��������+%������w��{.n�����{�� b���ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f