Re: [RFC PATCH 1/3] mfd: upboard: Add UP2 platform controller driver

[Pavel Machek <pavel@xxxxxx>]

On Wed 2018-05-02 12:26:50, Javier Arteaga wrote:
> On Tue, May 01, 2018 at 06:06:50PM +0100, Lee Jones wrote:
> > > Hmm... We do populate the struct mfd_cell array, although the way this
> > > patch series is structured, we leave it empty while we're only adding
> > > the MFD driver, and then fill it in later commits. I can instead
> > > introduce the cell array along with the first cell if you think that's
> > > more logical.
> > 
> > I do not accept drivers which do not provide a purpose, and without
> > child devices, this driver wouldn't actually do anything.
> 
> That makes sense. Though then I have only two other choices:
> 
> a) add the mfd driver + at least one child _in the same commit_,
> b) add the child drivers before the mfd parent within the series.
> 
> (a) feels wrong. And if I do (b) the child drivers won't be functional
> either until the parent (that implements the regmap) is introduced.
> 
> How to proceed?

Done within one series, that should be ok. I'd do (b).

									Pavel
									
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html