Re: [PATCH] gpio: mxc: Remove reliance on <linux/gpio.h>

[Shawn Guo <shawnguo@xxxxxxxxxx>]

On Thu, Apr 19, 2018 at 10:29:33AM +0200, Linus Walleij wrote:
> This is a driver so we should only include <linux/gpio.h>.
> However this driver was using gpio_get_value() to fetch the
> current value of a GPIO used as IRQ line to determine trigger
> direction, so we need a better way than looping over the
> global GPIO numberspace.
> 
> Fix this by just calling the .get() function in the GPIO chip,
> as we don't want to end up creating a consumer dependency
> on ourselves.
> 
> Cc: Vladimir Zapolskiy <vz@xxxxxxxxx>
> Cc: Fabio Estevam <fabio.estevam@xxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Other than Lars-Peter's comment on commit log,

Acked-by: Shawn Guo <shawnguo@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html