Re: [RFC PATCH 2/3] leds: upboard: Add LED support

[Javier Arteaga <javier@xxxxxxxxxx>]

Hi Jacek,

On Wed, Apr 25, 2018 at 08:25:59PM +0200, Jacek Anaszewski wrote:
> > diff --git a/drivers/leds/leds-upboard.c b/drivers/leds/leds-upboard.c
> > new file mode 100644
> > index 000000000000..e9d7a1fbcde4
> > --- /dev/null
> > +++ b/drivers/leds/leds-upboard.c
> > @@ -0,0 +1,87 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * UP Board LED driver
> > + *
> > + * Copyright (c) 2018, Emutex Ltd.
> > + *
> > + * Author: Javier Arteaga <javier@xxxxxxxxxx>
> > + */
> 
> Please use uniform '//' comment style here.

Will do!

(I was actually wondering about this one as I've seen both mixed C/C++
and C++-only comment blocks in other drivers, but I see now your
suggestion is indeed preferred style.)

> > +MODULE_LICENSE("GPL");
> 
> s/GPL/GPL v2/

I've fixed this now too.

Aside: this thread was one I mistakenly posted without proper Cc's to
linux-kernel. Other review comments are at:

    "[RFC PATCH RESEND 0/3] UP Squared board drivers"
    https://lkml.kernel.org/r/20180421085009.28773-1-javier@xxxxxxxxxx

Thank you for the review!
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html