Re: [PATCH] pinctrl: sunrisepoint: Align GPIO number space with Windows

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 29, 2018 at 04:45:47PM +0200, Hans de Goede wrote:
> > This should go to stable as well with following tags
> > 
> > Fixes: 551fa5801ef1 ("pinctrl: intel: sunrisepoint: Add Intel Sunrisepoint-H support")
> > Cc: stable@xxxxxxxxxxxxxxx
> > 
> > but there is dependency to following commits as well:
> > 
> >    03c4749dd6c7 ("gpio / ACPI: Drop unnecessary ACPI GPIO to Linux GPIO translation")
> >    a60eac3239f0 ("pinctrl: intel: Allow custom GPIO base for pad groups")
> >
> > I'm not sure whether they can be considered as stable material, though.
> 
> Given that:
> 
> https://github.com/torvalds/linux/commit/f5a26acf0162477af6ee4c11b4fb9cffe5d3e257.patch
> 
> Which is in 4.15.4 and later is causing a black screen on some model
> laptops because the wrong GPIO number is causing the backlight-enable
> pin to get configured wrongly, I don't think we have much choice here,
> unless you want to revert that commit from stable, we are going to
> need this patch as well as its 2 dependencies to fix the regression
> in the 4.15.x series.

Yes, I agree. Let's try to get this to stable with the dependencies.
That should result a working touchpad and prevent the backlight issue as
well.

I guess stable tags would then look like following, if I read
Documentation/process/stable-kernel-rules.rst correctly:

  Cc: stable@xxxxxxxxxxxxxxx # 03c4749dd6c7 ("gpio / ACPI: Drop unnecessary ACPI GPIO to Linux GPIO translation")
  Cc: stable@xxxxxxxxxxxxxxx # a60eac3239f0 ("pinctrl: intel: Allow custom GPIO base for pad groups")
  Cc: stable@xxxxxxxxxxxxxxx # v4.15

Linus, do you want me to resend the patch with these tags or are you
going to do that yourself?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux