[PATCH] gpio: fix ifnullfree.cocci warnings (fwd)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Fengguang Wu <fengguang.wu@xxxxxxxxx>

NULL check before kfree is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes: ad85ae608fe0 ("gpio: Remove VLA from gpiolib")
CC: Laura Abbott <labbott@xxxxxxxxxx>
Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx>

---

url:
https://github.com/0day-ci/linux/commits/Laura-Abbott/gpio-Remove-VLA-from-gpiolib/20180330-065639
base:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git
for-next

 gpiolib.c |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -2758,8 +2758,7 @@ int gpiod_get_array_value_complex(bool r

 		ret = gpio_chip_get_multiple(chip, mask, bits);
 		if (ret) {
-			if (slowpath)
-				kfree(slowpath);
+			kfree(slowpath);
 			return ret;
 		}

@@ -2774,8 +2773,7 @@ int gpiod_get_array_value_complex(bool r
 			trace_gpio_value(desc_to_gpio(desc), 1, value);
 		}

-		if (slowpath)
-			kfree(slowpath);
+		kfree(slowpath);
 	}
 	return 0;
 }
@@ -3020,8 +3018,7 @@ int gpiod_set_array_value_complex(bool r
 		if (count != 0)
 			gpio_chip_set_multiple(chip, mask, bits);

-		if (slowpath)
-			kfree(slowpath);
+		kfree(slowpath);
 	}
 	return 0;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux