Re: [PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Jan 16, 2018 at 1:45 PM, Baruch Siach <baruch@xxxxxxxxxx> wrote:

> The Raspberry Pi 3 has a GPIO expander that controls, among others, the
> activity LED, and the camera connector GPIOs. The GPIO expander on an I2C bus
> that is not directly controlled from the ARM core. The VC4 firmware controls
> the I2C bus, and allows the ARM core to set/get GPIO settings over its mailbox
> interface.
>
> This series adds support for the RPi3 expander.
>
> The driver is ported from the downstream kernel at
> https://github.com/raspberrypi/linux/, branch rpi-4.9.y.
>
> Changes in v3:
>
>   * Kconfig tweaks
>   * Check rpi_exp_gpio_get_polarity() return value
>   * Redundant header removal
>   * Redundant platform_set_drvdata() call removal
>   * Small coding style changes

All is looking pretty good. I see Rob had some last minute comments,
but please rebase and repost post v4.16-rc1 so we can get this merged,
we need to get this upstream.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html