Re: [PATCH] gpio: pca953x: add required properties to example in bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +- gpio-controller: Marks the device node as a GPIO controller
> > +- #gpio-cells: Must be '2':
> > +       - First cell is the GPIO line number
> > +       - Second cell is for optional parameters (currently unused)
> 
> Is it really unused?
> 
> I'd expect at least GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW to work,
> cfr. Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt

I rephrased it in a way which should be correct and no get stale over
time. Will send it right away.

> > @@ -44,4 +49,6 @@ Example:
> >                 pinctrl-0 = <&pinctrl_pca9505>;
> >                 interrupt-parent = <&gpio3>;
> >                 interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
> 
> Note that interrupts is also not documented.

I vote for incremental changes. I haven't tested that yet.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux