Re: [pinctrl:devel 63/65] drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type

[Stefan Agner <stefan@xxxxxxxx>]

On 2018-01-11 10:32, Linus Walleij wrote:
> On Wed, Jan 10, 2018 at 7:11 PM, Stefan Agner <stefan@xxxxxxxx> wrote:
>> Hi Linus,
>>
>> On 2018-01-09 17:40, kbuild test robot wrote:
>>> tree:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git
>>> devel
>>> head:   a3a093ae02e2ae81499ad9e78516dccd72906c25
>>> commit: ba33f4f42e968854d8367fc4e55b07f835c55832 [63/65] pinctrl:
>>> imx6ul: add IOMUXC SNVS pinctrl driver for i.MX 6ULL
>>> config: arm-multi_v7_defconfig (attached as .config)
>>> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
>>> reproduce:
>>>         wget
>>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>>> -O ~/bin/make.cross
>>>         chmod +x ~/bin/make.cross
>>>         git checkout ba33f4f42e968854d8367fc4e55b07f835c55832
>>>         # save the attached .config to linux build tree
>>>         make.cross ARCH=arm
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>>    drivers/pinctrl/freescale/pinctrl-imx6ul.c: In function
>>> 'imx6ul_pinctrl_probe':
>>>>> drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>>>      return imx_pinctrl_probe(pdev, pinctrl_info);
>>>                                     ^~~~~~~~~~~~
>>
>>
>> I think this happened because you only applied patch 5 of the imx
>> constify patchset, is that correct?
> 
> I have applied patches 1-4 now... patch 5 I can't even find in
> my inbox :(
> 
> So I guess not.
> 
> Can you have a look at my devel branch and send or resend a
> patch if something is still wrong?
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel

All patches are applied now. Note that Patch 5 ("pinctrl: imx6ul: add
IOMUXC SNVS pinctrl driver for i.MX 6ULL") is not authored by me, so
that is a bit confusing when looking at the git history.

The above warning has been triggered because patch 5 has been applied
before patch 1. I guess for strict bisectability it should be
reordered.. ("pinctrl: imx6ul: add IOMUXC SNVS pinctrl driver for i.MX
6ULL" should be after "pinctrl: imx: use struct imx_pinctrl_soc_info as
a const").

--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html