Re: [PATCH 5/6] pinctrl: sh-pfc: r8a7791: Add tpu groups and function

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Fabrizio,

On Thu, Dec 14, 2017 at 11:56 AM, Fabrizio Castro
<fabrizio.castro@xxxxxxxxxxxxxx> wrote:
> This patch adds tpu groups and function to r8a7743/r8a7791/r8a7793.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> Reviewed-by: Biju Das <biju.das@xxxxxxxxxxxxxx>

With the sort order fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> @@ -3892,6 +3892,32 @@ static const unsigned int sdhi2_wp_mux[] = {
>         SD2_WP_MARK,
>  };
>
> +/* - TPU -------------------------------------------------------------------- */
> +static const unsigned int tpu_to0_pins[] = {
> +       RCAR_GP_PIN(6, 14),
> +};
> +static const unsigned int tpu_to0_mux[] = {
> +       TPU_TO0_MARK,
> +};
> +static const unsigned int tpu_to1_pins[] = {
> +       RCAR_GP_PIN(1, 17),
> +};
> +static const unsigned int tpu_to1_mux[] = {
> +       TPU_TO1_MARK,
> +};
> +static const unsigned int tpu_to2_pins[] = {
> +       RCAR_GP_PIN(1, 18),
> +};
> +static const unsigned int tpu_to2_mux[] = {
> +       TPU_TO2_MARK,
> +};
> +static const unsigned int tpu_to3_pins[] = {
> +       RCAR_GP_PIN(1, 24),
> +};
> +static const unsigned int tpu_to3_mux[] = {
> +       TPU_TO3_MARK,
> +};
> +
>  /* - SSI -------------------------------------------------------------------- */
>  static const unsigned int ssi0_data_pins[] = {
>         /* SDATA */

Please use alphabetical sort order (also below).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html