"gpio-line-names" property - issue with commit 9427ecbed46cc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Mika,

In your commit 9427ecbed46cc, you have modified the way the "gpio-line-names" DT property is handled.

It seems that after that commit, many drivers fail to retrieve that property. After investigation it seems to be because the driver does not assign a parent to the gpio_chip.

Why is it necessary now to set a parent to the GPIO chip whereas it was not necessary before ? In gpio_chip_add_data(), we have:


	if (chip->parent) {
		gdev->dev.parent = chip->parent;
		gdev->dev.of_node = chip->parent->of_node;
	}

#ifdef CONFIG_OF_GPIO
	/* If the gpiochip has an assigned OF node this takes precedence */
	if (chip->of_node)
		gdev->dev.of_node = chip->of_node;
#endif



Therefore, as far as a chip->of_node is defined, shouldn't it be possible to retrieve "gpio-line-names" property as before without parent ?

Is there an easy modification that can be done to your new function devprop_gpiochip_set_names() in order to have the GPIO drivers work as before ?

Regards
Christophe
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux