Re: [PATCH] pinctrl: rockchip: enable clock when reading pin direction register

[Heiko Stuebner <heiko@xxxxxxxxx>]

Hi Brian,

Am Dienstag, 12. Dezember 2017, 09:43:43 CET schrieb Brian Norris:
> We generally leave the GPIO clock disabled, unless an interrupt is
> requested or we're accessing IO registers. We forgot to do this for the
> ->get_direction() callback, which means we can sometimes [1] get
> incorrect results [2] from, e.g., /sys/kernel/debug/gpio.
> 
> Enable the clock, so we get the right results!
> 
> [1] Sometimes, because many systems have 1 or mor interrupt requested on
> each GPIO bank, so they always leave their clock on.
> 
> [2] Incorrect, meaning the register returns 0, and so we interpret that
> as "input".
> 
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>

thanks for catching this and it looks good to me, so
Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html