Hi, On Thu, Oct 05, 2017 at 10:54:07PM +0200, Maxime Ripard wrote: > Old pinctrl drivers will need to disable strict mode for various reasons, > among which: > - Some DT will still have a pinctrl group for each GPIO used, which will > be rejected by pin_request. While we could remove those nodes, we still > have to deal with old DTs. > - Some GPIOs on these boards need to have their pin configuration changed > (for bias or current), and there's no clear migration path > > Let's disable the strict mode on those SoCs so that there's no breakage. > I revive this thread since I am facing the same issue. Did you find a way to deal with it? I have not seen a new version of this set of patches, I may have missed it. Why you didn't choose to add an optionnal property to enforce the use of the strict mode? I mean, with your solution, if there is a new DT with an old pin controller, it won't benefit from the strict mode. Ludovic > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> > --- > drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c | 1 + > drivers/pinctrl/sunxi/pinctrl-sun5i.c | 1 + > drivers/pinctrl/sunxi/pinctrl-sun6i-a31.c | 1 + > drivers/pinctrl/sunxi/pinctrl-sun8i-a23.c | 1 + > drivers/pinctrl/sunxi/pinctrl-sun8i-a33.c | 1 + > drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c | 3 ++- > drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c | 1 + > 7 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c b/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c > index f763d8d62d6e..295e48fc94bc 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c > +++ b/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c > @@ -1289,6 +1289,7 @@ static const struct sunxi_pinctrl_desc sun4i_a10_pinctrl_data = { > .npins = ARRAY_SIZE(sun4i_a10_pins), > .irq_banks = 1, > .irq_read_needs_mux = true, > + .disable_strict_mode = true, > }; > > static int sun4i_a10_pinctrl_probe(struct platform_device *pdev) > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun5i.c b/drivers/pinctrl/sunxi/pinctrl-sun5i.c > index 47afd558b114..27ec99e81c4c 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sun5i.c > +++ b/drivers/pinctrl/sunxi/pinctrl-sun5i.c > @@ -713,6 +713,7 @@ static const struct sunxi_pinctrl_desc sun5i_pinctrl_data = { > .pins = sun5i_pins, > .npins = ARRAY_SIZE(sun5i_pins), > .irq_banks = 1, > + .disable_strict_mode = true, > }; > > static int sun5i_pinctrl_probe(struct platform_device *pdev) > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun6i-a31.c b/drivers/pinctrl/sunxi/pinctrl-sun6i-a31.c > index 951a25c18815..82ffaf466892 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sun6i-a31.c > +++ b/drivers/pinctrl/sunxi/pinctrl-sun6i-a31.c > @@ -965,6 +965,7 @@ static const struct sunxi_pinctrl_desc sun6i_a31_pinctrl_data = { > .pins = sun6i_a31_pins, > .npins = ARRAY_SIZE(sun6i_a31_pins), > .irq_banks = 4, > + .disable_strict_mode = true, > }; > > static int sun6i_a31_pinctrl_probe(struct platform_device *pdev) > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-a23.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-a23.c > index 721b6935baf3..402fd7d21e7b 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sun8i-a23.c > +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-a23.c > @@ -563,6 +563,7 @@ static const struct sunxi_pinctrl_desc sun8i_a23_pinctrl_data = { > .pins = sun8i_a23_pins, > .npins = ARRAY_SIZE(sun8i_a23_pins), > .irq_banks = 3, > + .disable_strict_mode = true, > }; > > static int sun8i_a23_pinctrl_probe(struct platform_device *pdev) > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-a33.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-a33.c > index ef1e0bef4099..da387211a75e 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sun8i-a33.c > +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-a33.c > @@ -486,6 +486,7 @@ static const struct sunxi_pinctrl_desc sun8i_a33_pinctrl_data = { > .npins = ARRAY_SIZE(sun8i_a33_pins), > .irq_banks = 2, > .irq_bank_base = 1, > + .disable_strict_mode = true, > }; > > static int sun8i_a33_pinctrl_probe(struct platform_device *pdev) > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c > index 518a92df4418..d1719a738c20 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c > +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c > @@ -491,7 +491,8 @@ static const struct sunxi_pinctrl_desc sun8i_h3_pinctrl_data = { > .pins = sun8i_h3_pins, > .npins = ARRAY_SIZE(sun8i_h3_pins), > .irq_banks = 2, > - .irq_read_needs_mux = true > + .irq_read_needs_mux = true, > + .disable_strict_mode = true, > }; > > static int sun8i_h3_pinctrl_probe(struct platform_device *pdev) > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c b/drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c > index bc14e954d7a2..472ef0d91b99 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c > +++ b/drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c > @@ -721,6 +721,7 @@ static const struct sunxi_pinctrl_desc sun9i_a80_pinctrl_data = { > .pins = sun9i_a80_pins, > .npins = ARRAY_SIZE(sun9i_a80_pins), > .irq_banks = 5, > + .disable_strict_mode = true, > }; > > static int sun9i_a80_pinctrl_probe(struct platform_device *pdev) > -- > git-series 0.9.1 > -- > To unsubscribe from this list: send the line "unsubscribe linux-gpio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html