On Sat, Dec 02, 2017 at 05:00:03PM +0100, Linus Walleij wrote: > On Fri, Dec 1, 2017 at 2:44 PM, Quentin Schulz > <quentin.schulz@xxxxxxxxxxxxxxxxxx> wrote: > > > The AXP209 and AXP813 PMICs have several pins (respectively 3 and 2) that can > > be used either as GPIOs or for other purposes (ADC or LDO here). > > > > We already have a GPIO driver for the GPIO use of those pins on the AXP209. > > Let's "upgrade" this driver to support all the functions these pins can have. > > > > Then we add support to this driver for the AXP813 which is slighlty different > > (basically a different offset in two registers and one less pin). > > > > I suggest patches 1 to 8 go through Linus's tree and 9 and 10 via Maxime or > > Chen-Yu's tree. > > > > v4: > > Looks overall good. As soon as Maxime is happy with everything I will > happily apply 1-8 to the pinctrl tree and then pull it to GPIO as well to > avoid clashes. > > I think there were some minor comments but it seems almost finished. You can apply everything with my Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> The only comment left is the checkpatch warning, but there's multiple occurences of that issue in the driver, so it can definitely be done in a separate patch. (But please do it Quentin ;)) Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature
