On Mon, Dec 04, 2017 at 05:08:15PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> In the (unlikely) event that community->ngpps is zero, or if every
> gpp->gpio_base is less than zero, then an ininitialized value in
> ret is returned by function intel_gpio_add_pin_ranges. Fix this by
> ensuring ret is initialized to zero. It's a moot point, but I think
> it is worthwhile ensuring this corner case is fixed.
I agree.
> Detected by CoverityScan, CID#1462415 ("Uninitialized scalar variable")
>
> Fixes: a60eac3239f0 ("pinctrl: intel: Allow custom GPIO base for pad groups")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH][next] pinctrl: intel: ensure error return ret is initialized
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH][next] pinctrl: intel: ensure error return ret is initialized
- From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
- Date: Mon, 4 Dec 2017 19:23:04 +0200
- In-reply-to: <20171204170815.14779-1-colin.king@canonical.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20171204170815.14779-1-colin.king@canonical.com>
- User-agent: Mutt/1.9.1 (2017-09-22)
- References:
- [PATCH][next] pinctrl: intel: ensure error return ret is initialized
- From: Colin King
- [PATCH][next] pinctrl: intel: ensure error return ret is initialized
- Prev by Date: [PATCH][next] pinctrl: intel: ensure error return ret is initialized
- Next by Date: Re: [PATCH] pinctrl: gemini: Support drive strength setting
- Previous by thread: [PATCH][next] pinctrl: intel: ensure error return ret is initialized
- Next by thread: Re: [PATCH][next] pinctrl: intel: ensure error return ret is initialized
- Index(es):
 |